ncu fails with "TypeError: dep.includes is not a function" for package.json with bundleDependencies

[tsondergaard]

• I have searched for similar issues
• I am using the latest version of npm-check-updates
• I am using node >= 14.14

---

Steps to Reproduce

Steps:

mkdir example
cd example
npm init --force
npm install --save --save-bundle tmp uuid
npm install --no-save npm-check-updates
npx ncu -u

Current Behavior

ncu -u fails with the following output:

Upgrading /home/ts/src/example/package.json
[====================] 1/1 100%
TypeError: dep.includes is not a function
    at /home/ts/src/example/node_modules/npm-check-updates/build/src/lib/getPreferredWildcard.js:22:134
    at Array.find (<anonymous>)
    at /home/ts/src/example/node_modules/npm-check-updates/build/src/lib/getPreferredWildcard.js:22:104
    at arrayAggregator (/home/ts/src/example/node_modules/lodash/_arrayAggregator.js:17:32)
    at /home/ts/src/example/node_modules/lodash/_createAggregator.js:19:12
    at getPreferredWildcard (/home/ts/src/example/node_modules/npm-check-updates/build/src/lib/getPreferredWildcard.js:22:42)
    at upgradeDependencies (/home/ts/src/example/node_modules/npm-check-updates/build/src/lib/upgradeDependencies.js:49:57)
    at upgradePackageDefinitions (/home/ts/src/example/node_modules/npm-check-updates/build/src/lib/upgradePackageDefinitions.js:29:68)
    at async runLocal (/home/ts/src/example/node_modules/npm-check-updates/build/src/lib/runLocal.js:163:65)
    at async runUpgrades (/home/ts/src/example/node_modules/npm-check-updates/build/src/index.js:215:20)

Expected Behavior

ncu -u completes without an error

Versions:

$ node --version
v18.1.0
$ npm --version
8.8.0
$ npx ncu --version
16.6.0

[raineorshine]

After a little research I've determined, amusingly, that the bundleDependencies logic is completely erroneous. I assumed bundleDependencies had the same format as the other dependencies sections when I added it back in d319202. It's just an array of package names, so there is nothing there to upgrade! 🤦‍♀️

Apparently bundleDependencies isn't used very often, as this hasn't come up in the 3.5 years it has been lurking in npm-check-updates.

Removed and published to v16.6.1 :).

[gklasen]

Hey @raineorshine , unfortunately, i still have this error with v16.6.2.

After some investigation, i found out that this always happens if it a dependency is splitted into an "id" and "locator" parameter, like:

"ImagePicker": {
  "id": "ImagePicker",
  "locator": "https://github.com/dhavalsoni2001/ImagePicker.git"
}

[raineorshine]

@gklasen I wasn't aware of that dependency format. Could you link me to documentation? I don't see it in npm's docs: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#dependencies

[gklasen]

The project i was updating was couple of years old. I think you can ignore, as they (npm) seem to have removed this possibility.