Skip to content

Conversation

bonflintstone
Copy link
Contributor

What changes are introduced?

Only some cleanup since the feature seems already implemented.

Why are these changes introduced?

See #324

How are these changes made?

🧹

How was it tested? (optional)

remove this section, when you don't add further information

Some code, especially infrastructure code (say HELM or Kubernetes yaml files) are harder to test. So it’s important to let the reviewer know how you tested them in case you can’t check in tests. Alternatively, you can explain to the reviewer how to test it locally if necessary. Showing the results of tests you’ve run in this section if none are visible in the diff is also very helpful.

  • Specs
  • Locally
  • Staging

Hints for Reviews? (optional)

remove this section, when you don't attach further hints

Screenshots, Sample Data
Before After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant