Skip to content

Downgrade rubygems version to fix CI #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Jun 5, 2018

ref:

I'm looking forward the way to pass entire tests with latest rubygems though, I hope this PR can be a quick fix for our broken CI.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @grosser (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mtsmfm mtsmfm force-pushed the fix-broken-ci-2 branch from ee7d5f3 to 05402c2 Compare June 5, 2018 14:59
@grosser
Copy link
Collaborator

grosser commented Jun 5, 2018

still kinda broken ... is it better than before ?

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Jun 5, 2018

Yeah, I think it's much better than before because this change fixes the following LoadError we met on master branch:

/home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/site_ruby/2.2.0/bundler/runtime.rb:313:in `check_for_activated_spec!': You have already activated i18n 1.0.1, but your Gemfile requires i18n 0.9.5. Prepending `bundle exec` to your command may solve this. (Gem::LoadError)

It once passed when I tried on my forked repo:

https://travis-ci.org/mtsmfm/spring/builds/388306637

So I thought it can fix but actually still fail...

@grosser grosser merged commit 6f1203a into rails:master Jun 5, 2018
@grosser
Copy link
Collaborator

grosser commented Jun 5, 2018

forward progress 🎉 keep the PRs coming :)

@mtsmfm mtsmfm deleted the fix-broken-ci-2 branch June 5, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants