Improve CLI parallelism #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
improve-parallelism
branch
from
ddb66a9 to
5cc0f1f
Compare
When building cross platform images with Docker, QEMU is often used under the hood and can have a bug that cause forked processes to deadlock. Before spawning workers we test for that bug. Fix: #495 Closes: #497 Co-Authored-By: Sarun Rattanasiri <[email protected]>
casperisfine
force-pushed
the
improve-parallelism
branch
from
5cc0f1f to
d603b70
Compare
n00dle
reviewed
May 15, 2025
| return nil if cpu_max.start_with?("max ") # no limit | ||
|
|
||
| max, period = cpu_max.split.map(&:to_f) | ||
| max / period |
There was a problem hiding this comment.
These lines (and lines 53/54) are returning a float, causing issues later on when trying to spawn the worker pool. This is the error from our CI:
/home/circleci/tmp/vendor/bundle/ruby/3.1.0/gems/bootsnap-1.18.5/lib/bootsnap/cli/worker_pool.rb:164:in `spawn': undefined method `times' for 4.0:Float (NoMethodError)
@workers = @size.times.map { Worker.new(@jobs) }
^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #495
Closes: #497
I'm waiting on a confirmation that the bug detection work as expected, once I have it I'll cut a release.