Code cleanup #2369
Merged
Code cleanup #2369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'thread_safe' gem is now deprecated and merged into 'concurrent-ruby'. Ref: ruby-concurrency/concurrent-ruby@52e5f37#diff-42d5a45da331eaa07d2b315bd3c9e738
bf4
reviewed
Jan 3, 2020
| @@ -73,7 +73,7 @@ def self.serializer_lookup_chain_for(klass, namespace = nil) | |||
| # Used to cache serializer name => serializer class | |||
| # when looked up by Serializer.get_serializer_for. | |||
| def self.serializers_cache | |||
| @serializers_cache ||= ThreadSafe::Cache.new | |||
| @serializers_cache ||= Concurrent::Map.new | |||
There was a problem hiding this comment.
kind of odd. I'm not sure where the dependency is coming from. I know later versions of Rails introduce concurrent-ruby. I guess thread_safe was coming from active_support?
There was a problem hiding this comment.
thread_safe is needed by 2 different sources:
active_support(4.2.11.1)grape(0.19.0) (throughvirtus)
bf4
reviewed
Jan 3, 2020
| def link(name, value = nil) | ||
| options[:links][name] = block_given? ? Proc.new : value | ||
| def link(name, value = nil, &block) | ||
| options[:links][name] = block_given? ? block : value |
There was a problem hiding this comment.
I'm installing 2.7 locally so I can figure out what you're seeing. As I wrote in the other PR, this change doesn't make sense to me
There was a problem hiding this comment.
ok, this makes more sense
lib/active_model/serializer/reflection.rb:91: warning: Capturing the given block using Proc.new is
deprecated; use&blockinstead
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.