Skip to content

Tidy up the tests #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2016
Merged

Tidy up the tests #1423

merged 1 commit into from
Jan 12, 2016

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Jan 11, 2016

  • Use assert_nil where appropriate - assert_nil is equivalent to assert_equal with nil as the expectation, so the failure message should be the same. http://apidock.com/ruby/Test/Unit/Assertions/assert_nil
  • Lead with the expected value in collection_serializer_test.rb, etc
    so that expected/actual in test failure messages are not reversed

@Empact
Tidy up the tests
0a6c133 
* Use assert_nil where appropriate
* Lead with the expected value in collection_serializer_test.rb, etc
 so that expected/actual in test failure messages are not reversed
@Empact Empact mentioned this pull request Jan 11, 2016
Merged
bf4 added a commit that referenced this pull request Jan 12, 2016
@bf4
Merge pull request #1423 from brigade/tidy-tests
34e5faa 
Tidy up the tests
@bf4 bf4 merged commit 34e5faa into rails-api:master Jan 12, 2016
@bf4
Copy link
Member

bf4 commented Jan 12, 2016

Great!

@bf4 bf4 mentioned this pull request Jan 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Cleanup V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Empact @bf4