Skip to content

Feature/add dugong#2053

Merged
dhedey merged 6 commits into
developfrom
feature/add-dugong
Jan 15, 2025
Merged

Feature/add dugong#2053
dhedey merged 6 commits into
developfrom
feature/add-dugong

Conversation

@dhedey
Copy link
Copy Markdown
Contributor

@dhedey dhedey commented Jan 13, 2025

Summary

Added ProtocolUpdate::Dugong and the easiest update on the list - to tweak some metadata.

I also did a small bit of refactoring in a few places to make it very easy to define metadata updates; and removed/fixed some other bits which were outdated.

Testing

Existing tests pass

Changelog

Added the native package metadata update under "other changes"

@dhedey dhedey requested a review from a team as a code owner January 13, 2025 19:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 13, 2025

Docker tags
docker.io/radixdlt/private-scrypto-builder:4f96e67399

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 13, 2025

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:4f96e67399

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 13, 2025

Benchmark for 4f96e67

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.4±0.09ms 45.1±0.13ms +1.58%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.8±0.04ms 19.3±0.02ms -2.53%
costing::decode_encoded_i8_array_to_manifest_value 42.3±0.04ms 42.3±0.06ms 0.00%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.1±0.09ms 72.2±0.05ms +0.14%
costing::decode_encoded_tuple_array_to_manifest_value 98.2±0.19ms 102.1±0.16ms +3.97%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.4±0.05µs 25.6±0.08µs -20.99%
costing::decode_encoded_u8_array_to_manifest_value 42.0±0.08ms 42.1±0.06ms +0.24%
costing::decode_rpd_to_manifest_raw_value 14.6±0.04µs 14.4±0.04µs -1.37%
costing::decode_rpd_to_manifest_value 10.9±0.03µs 10.8±0.03µs -0.92%
costing::deserialize_wasm 1232.4±3.44µs 1251.9±8.15µs +1.58%
costing::execute_transaction_creating_big_vec_substates 707.7±11.99ms 707.6±8.89ms -0.01%
costing::execute_transaction_reading_big_vec_substates 620.7±1.25ms 588.1±2.72ms -5.25%
costing::instantiate_flash_loan 890.8±437.72µs 1016.9±1045.80µs +14.16%
costing::instantiate_radiswap 1009.6±1545.37µs 1102.7±1697.22µs +9.22%
costing::scrypto_malloc 687.0±0.93ms 666.5±3.84ms -2.98%
costing::scrypto_sbor_decode 697.7±1.43ms 683.7±1.11ms -2.01%
costing::scrypto_sha256 608.6±1.35ms 592.9±0.86ms -2.58%
costing::spin_loop_v1 519.3±2.23ms 512.7±0.93ms -1.27%
costing::spin_loop_v2 595.5±0.92ms 600.8±0.42ms +0.89%
costing::validate_sbor_payload 29.6±0.05µs 32.1±0.05µs +8.45%
costing::validate_sbor_payload_bytes 244.9±0.64ns 259.5±0.64ns +5.96%
costing::validate_secp256k1 76.8±0.10µs 76.7±0.36µs -0.13%
costing::validate_wasm 33.6±0.07ms 33.8±0.04ms +0.60%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.01ns 9.8±0.00ns 0.00%
decimal::add/wasmi 319.7±2.84ns 317.5±1.89ns -0.69%
decimal::add/wasmi-call-native 2.9±0.01µs 2.9±0.00µs 0.00%
decimal::div/0 168.9±0.29ns 169.1±0.17ns +0.12%
decimal::from_string/0 156.1±0.21ns 155.9±0.07ns -0.13%
decimal::mul/0 129.4±0.06ns 129.4±0.03ns 0.00%
decimal::mul/rust-native 127.0±0.12ns 124.9±0.07ns -1.65%
decimal::mul/wasmi 18.9±0.09µs 19.4±0.03µs +2.65%
decimal::mul/wasmi-call-native 3.1±0.01µs 3.0±0.01µs -3.23%
decimal::pow/0 592.5±0.19ns 592.6±0.54ns +0.02%
decimal::pow/rust-native 593.3±0.34ns 598.6±1.19ns +0.89%
decimal::pow/wasmi 91.5±0.29µs 92.2±0.32µs +0.77%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.8±0.01µs 0.00%
decimal::root/0 8.1±0.01µs 8.1±0.01µs 0.00%
decimal::sub/0 8.3±0.01ns 8.3±0.01ns 0.00%
decimal::to_string/0 446.5±0.19ns 441.0±0.38ns -1.23%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.3±0.01ms 6.5±0.02ms +3.17%
large_transaction_processing::prepare_and_decompile_and_recompile 30.2±2.06ms 31.2±1.52ms +3.31%
metadata_validation::validate_urls 5.1±0.05µs 4.8±0.02µs -5.88%
precise_decimal::add/0 8.7±0.05ns 8.7±0.02ns 0.00%
precise_decimal::add/rust-native 10.7±0.09ns 10.7±0.01ns 0.00%
precise_decimal::add/wasmi 434.4±2.91ns 425.5±3.88ns -2.05%
precise_decimal::add/wasmi-call-native 3.8±0.02µs 3.8±0.00µs 0.00%
precise_decimal::div/0 292.9±1.73ns 300.9±0.62ns +2.73%
precise_decimal::from_string/0 204.3±0.23ns 206.1±0.14ns +0.88%
precise_decimal::mul/0 331.2±3.19ns 341.2±1.26ns +3.02%
precise_decimal::mul/rust-native 288.1±0.29ns 283.8±0.74ns -1.49%
precise_decimal::mul/wasmi 47.8±0.16µs 47.6±0.17µs -0.42%
precise_decimal::mul/wasmi-call-native 4.2±0.01µs 4.1±0.01µs -2.38%
precise_decimal::pow/0 1735.4±1.87ns 1729.9±1.33ns -0.32%
precise_decimal::pow/rust-native 1358.4±0.75ns 1354.3±0.85ns -0.30%
precise_decimal::pow/wasmi 227.5±0.56µs 228.0±0.97µs +0.22%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.4±0.01µs -1.33%
precise_decimal::root/0 57.9±0.03µs 58.3±0.02µs +0.69%
precise_decimal::sub/0 8.9±0.13ns 8.9±0.10ns 0.00%
precise_decimal::to_string/0 696.4±0.50ns 689.4±1.14ns -1.01%
schema::validate_payload 385.8±0.45µs 388.7±0.49µs +0.75%
transaction::radiswap 5.1±0.03ms 5.0±0.03ms -1.96%
transaction::transfer 1820.1±4.28µs 1799.0±3.10µs -1.16%
transaction_validation::validate_manifest 43.2±0.07µs 43.1±0.06µs -0.23%
transaction_validation::verify_bls_2KB 1061.1±26.24µs 1000.4±3.76µs -5.72%
transaction_validation::verify_bls_32B 1003.1±10.53µs 1002.5±7.55µs -0.06%
transaction_validation::verify_ecdsa 74.7±0.16µs 74.6±0.08µs -0.13%
transaction_validation::verify_ed25519 42.4±0.08µs 42.1±0.11µs -0.71%

Comment thread CHANGELOG.md Outdated
> Other incidental features or changes which shouldn't break existing integrations, but are worthy of mention to scrypto developers, dApp developers or other integrators.

* *Pending...*
* Minor updates to improve the `name` and `description` of the native node module packages.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entry can reference this PR? which can be helpful? i.e. each change log entry can contain reference to the PR introducing the change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good shout 👍

@dhedey dhedey requested a review from a team as a code owner January 14, 2025 12:10
Copy link
Copy Markdown
Contributor

@iamyulong iamyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhedey dhedey merged commit ddd968a into develop Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants