Explicitly mark stop_engines non-async for state consistency and generalize stop_engines inputs#943
Open
fzyzcjy wants to merge 9 commits intorollout_ft/25from
Open
Explicitly mark stop_engines non-async for state consistency and generalize stop_engines inputs#943fzyzcjy wants to merge 9 commits intorollout_ft/25from
fzyzcjy wants to merge 9 commits intorollout_ft/25from
Conversation
fzyzcjy
requested review from
guapisolo,
maocheng23 and
yueming-yuan
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the stop_engines method in ServerGroup to an asynchronous function and updates its internal call to use await instead of ray.get. Additionally, the health_monitor.py file is updated to invoke this new asynchronous method using a run utility. I have no feedback to provide.
This reverts commit 8c3473f.
fzyzcjy
changed the title
fzyzcjy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.