Skip to content

Conversation

C4tion
Copy link
Contributor

@C4tion C4tion commented Feb 15, 2023

Rescue the client window group instead of the client window on unsplitting.
Also small stuff I stumbled upon.

Someone who knows what they are doing should review this. It might fail spectacularly in some cases.
I have no clue why every client window is managed by a client window group.

Generating a graph of the objects and managing relation helped debugging the issue:

echo "digraph managing {$(notionflux << EOF | grep -v '^nil$'

function label(sub)
    return tostring(sub) .. (sub:name() and " (" .. sub:name() .. ")" or "");
end

function dump(sub)
    print("\"" .. label(sub:manager()) .. "\" -> \"" .. label(sub) .. "\";");
    return true;
end

notioncore.clientwin_i(dump)
notioncore.region_i(dump)

EOF
)}" | dot -Tpng -o /tmp/graph.png

fixes #316

Fixes this warning:
Object destroyed while deferred actions are still pending.
Fixes raboof#316. The client window group was missing after the unsplitting,
so the bindmaps of WGroup/WGroupCW were not active.
@C4tion C4tion changed the title Fix #316 Fix issue #316 Feb 15, 2023
@raboof raboof changed the title Fix issue #316 Rescue the client window group instead of the client window on unsplitting Feb 15, 2023
@raboof
Copy link
Owner

raboof commented Feb 15, 2023

/cc @dkogan would you have a chance to look at / test this?

@dkogan
Copy link
Contributor

dkogan commented Feb 17, 2023 via email

@raboof raboof merged commit aa7f8cb into raboof:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent bug in notion 4: META-Return (full-screen) sometimes ignored
3 participants