Gentoo patches #341
Merged
Gentoo patches #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `LDFLAGS` needs to come very early on the command line, since most linker flags only affect object files after it, not before.
`$(CC)` will default to `cc` when not specified.
* These are specified in POSIX and actually lack `CPPFLAGS` when using GNU Make.
raboof
approved these changes
Jun 12, 2022
wilhelmy
reviewed
Jun 13, 2022
| @@ -65,24 +67,24 @@ LUAC=$(LUA_DIR)/bin/luac | |||
|
|
|||
| ifndef LUA_MANUAL | |||
|
|
|||
There was a problem hiding this comment.
Makes me wonder if this entire section isn't actually duplicated here from build/lua-detect.mk, libextl lives in-tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @raboof
I'd like to upstream the patches for
notionwe need in Gentoo.