Fix window_dialog_float not taken into account #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When window_dialog_float is false, which is the case by default, floating dialog windows are enabled anyway. REGION_PLEASE_FLOAT should not be added to region flags in that case.
vincentvidal
force-pushed
the
fix-window-dialog-float
branch
from
3e05649 to
b8b0c41
Compare
|
If I understand correctly, now we should not get floating dialogs by default, which we should've been getting since this feature was implemented. Just a warning, I was never bothered by it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When window_dialog_float is false, which is the case by default, floating dialog windows are enabled anyway. REGION_PLEASE_FLOAT should not be added to region flags in that case.
fixes #61