Improved Lua version detection and Lua 5.3 support #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variadic functions were introduced in 5.0, but the method of accessing them changed in 5.1. This makes the code incompatible with 5.0 (it is already incompatible since at least b2b1755), which will be removed from the build system in a subsequent commit. Fixes raboof#124. See also raboof#90.
Lua doesn't include an official pkg-config file, therefore we can't rely on pkg-config variables like "V" or "major_version" - on my system, it detected the 5.3 library/cflags and used the 5.1 lua/luac binaries (I have both installed and there was a fallback to 5.1 if it couldn't query these variables from pkg-config).
|
This drops support for Lua 5.0 and fixes #124 |
raboof
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.