Priority queue: Fix a crash when querying 'head_message_timestamp' #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, the code would consider it an integer which could be summed. It crashed if the head message had no timestamp at all (the underlying queue returned ''). Now, we have a special case, exactly like 'backing_queue_status'. The code first finds a priority with queued messages, then it queries the underlying queue for the 'head_message_timestamp'. Fixes #245.
michaelklishin
added a commit
that referenced
this pull request
Aug 6, 2015
Priority queue: Fix a crash when querying 'head_message_timestamp'
ansd
added a commit
that referenced
this pull request
Jul 5, 2022
My workflow is developing RabbitMQ on an Ubuntu server. Since it doesn't have a desktop or browser, let's fallback for `bazel run test-logs` command to start an HTTP server instead. From now on, I can run conveniently: ``` david@nuc:~/workspace/rabbitmq-server$ bazel run test-logs //deps/rabbitmq_auth_backend_oauth2:unit_SUITE --config=local INFO: Analyzed target //:test-logs (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //:test-logs up-to-date: bazel-bin/open-test-logs.sh INFO: Elapsed time: 0.047s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action INFO: Build completed successfully, 1 total action Archive: outputs.zip Couldn't find a suitable web browser! Set the BROWSER environment variable to your desired browser. Warning: program returned non-zero exit code #256 /usr/bin/open: 882: www-browser: not found /usr/bin/open: 882: links2: not found /usr/bin/open: 882: elinks: not found /usr/bin/open: 882: links: not found /usr/bin/open: 882: lynx: not found /usr/bin/open: 882: w3m: not found xdg-open: no method available for opening 'index.html' Open your browser at http://nuc:8000/index.html Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ... ``` and then open http://nuc:8000/index.html in my browser on MacOS.
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
My workflow is developing RabbitMQ on an Ubuntu server. Since it doesn't have a desktop or browser, let's fallback for `bazel run test-logs` command to start an HTTP server instead. From now on, I can run conveniently: ``` david@nuc:~/workspace/rabbitmq-server$ bazel run test-logs //deps/rabbitmq_auth_backend_oauth2:unit_SUITE --config=local INFO: Analyzed target //:test-logs (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //:test-logs up-to-date: bazel-bin/open-test-logs.sh INFO: Elapsed time: 0.047s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action INFO: Build completed successfully, 1 total action Archive: outputs.zip Couldn't find a suitable web browser! Set the BROWSER environment variable to your desired browser. Warning: program returned non-zero exit code #256 /usr/bin/open: 882: www-browser: not found /usr/bin/open: 882: links2: not found /usr/bin/open: 882: elinks: not found /usr/bin/open: 882: links: not found /usr/bin/open: 882: lynx: not found /usr/bin/open: 882: w3m: not found xdg-open: no method available for opening 'index.html' Open your browser at http://nuc:8000/index.html Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ... ``` and then open http://nuc:8000/index.html in my browser on MacOS. (cherry picked from commit 107b8a4)
mergify bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
My workflow is developing RabbitMQ on an Ubuntu server. Since it doesn't have a desktop or browser, let's fallback for `bazel run test-logs` command to start an HTTP server instead. From now on, I can run conveniently: ``` david@nuc:~/workspace/rabbitmq-server$ bazel run test-logs //deps/rabbitmq_auth_backend_oauth2:unit_SUITE --config=local INFO: Analyzed target //:test-logs (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //:test-logs up-to-date: bazel-bin/open-test-logs.sh INFO: Elapsed time: 0.047s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action INFO: Build completed successfully, 1 total action Archive: outputs.zip Couldn't find a suitable web browser! Set the BROWSER environment variable to your desired browser. Warning: program returned non-zero exit code #256 /usr/bin/open: 882: www-browser: not found /usr/bin/open: 882: links2: not found /usr/bin/open: 882: elinks: not found /usr/bin/open: 882: links: not found /usr/bin/open: 882: lynx: not found /usr/bin/open: 882: w3m: not found xdg-open: no method available for opening 'index.html' Open your browser at http://nuc:8000/index.html Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ... ``` and then open http://nuc:8000/index.html in my browser on MacOS. (cherry picked from commit 107b8a4) (cherry picked from commit bae7e9d)
michaelklishin
pushed a commit
that referenced
this pull request
Jul 8, 2022
My workflow is developing RabbitMQ on an Ubuntu server. Since it doesn't have a desktop or browser, let's fallback for `bazel run test-logs` command to start an HTTP server instead. From now on, I can run conveniently: ``` david@nuc:~/workspace/rabbitmq-server$ bazel run test-logs //deps/rabbitmq_auth_backend_oauth2:unit_SUITE --config=local INFO: Analyzed target //:test-logs (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //:test-logs up-to-date: bazel-bin/open-test-logs.sh INFO: Elapsed time: 0.047s, Critical Path: 0.00s INFO: 1 process: 1 internal. INFO: Build completed successfully, 1 total action INFO: Build completed successfully, 1 total action Archive: outputs.zip Couldn't find a suitable web browser! Set the BROWSER environment variable to your desired browser. Warning: program returned non-zero exit code #256 /usr/bin/open: 882: www-browser: not found /usr/bin/open: 882: links2: not found /usr/bin/open: 882: elinks: not found /usr/bin/open: 882: links: not found /usr/bin/open: 882: lynx: not found /usr/bin/open: 882: w3m: not found xdg-open: no method available for opening 'index.html' Open your browser at http://nuc:8000/index.html Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ... ``` and then open http://nuc:8000/index.html in my browser on MacOS. (cherry picked from commit 107b8a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the code would consider it an integer which could be summed. It crashed if the head message had no timestamp at all (the underlying queue returned
'').Now, we have a special case, exactly like
backing_queue_status. The code first finds a priority with queued messages, then it queries the underlying queue for thehead_message_timestamp.Fixes #245.