Skip to content

Do not "pre convert" running_nodes to strings #14381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Do not "pre convert" running_nodes to strings #14381

merged 1 commit into from
Aug 13, 2025

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Aug 13, 2025 •
edited
Loading

Follow-up to #14118

Without this PR:

$ ./sbin/rabbitmqctl -n rabbit-1 cluster_status --formatter=json | jq '.running_nodes'
"rabbit-3@SEA-3LG5HVJUWJKrabbit-2@SEA-3LG5HVJUWJKrabbit-1@SEA-3LG5HVJUWJK"

With this PR:

$ ./sbin/rabbitmqctl -n rabbit-1 cluster_status --formatter=json | jq '.running_nodes'
[
  "rabbit-3@SEA-3LG5HVJUWJK",
  "rabbit-2@SEA-3LG5HVJUWJK",
  "rabbit-1@SEA-3LG5HVJUWJK"
]

@lukebakken lukebakken self-assigned this Aug 13, 2025
the-mikedavis
the-mikedavis approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine too 👍

@michaelklishin michaelklishin added this to the 4.2.0 milestone Aug 13, 2025
@michaelklishin michaelklishin merged commit 0da2ee8 into rabbitmq:main Aug 13, 2025
280 of 281 checks passed
@michaelklishin
Copy link
Collaborator

Thank you for the quick turnaround, @lukebakken @the-mikedavis!

michaelklishin added a commit that referenced this pull request Aug 13, 2025
@michaelklishin
Merge pull request #14382 from rabbitmq/mergify/bp/v4.1.x/pr-14381
b19fd89 
Do not "pre convert" `running_nodes` to strings (backport #14381)
@ansd
Copy link
Member

ansd commented Aug 13, 2025

Thank you @lukebakken and @the-mikedavis !

@lukebakken lukebakken deleted the lukebakken/pr-14118-followup branch August 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
backport-v4.1.x
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lukebakken @michaelklishin @ansd @the-mikedavis