Use relative path for the path linked to the cookie #13664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used by mangement ui oauth logic to store the token until it is moved onto the local storage
michaelklishin
approved these changes
Apr 1, 2025
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Apr 1, 2025
Use relative path for the path linked to the cookie (backport #13664)
Merged
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes a regression added to the management ui's oauth authentication. This regression occurs only when the ui is mounted on a custom path.
Use relative path for the path linked to the cookie used by manegement ui's oauth logic to store the token until it is moved onto the local storage.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply