[Reverted] Increase initial AMQP 0-9-1 connection frame size limit (backport #13542) (backport #13543) #13544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Before the client authenticates, the standard frame_max is not used. Instead, the limit is a special constant. This is fine for password or x.509 certificate-based authentication but not for some JWT tokens, which can vary in size, and take multiple kilobytes. 8 kB specifically is the default HTTP header length limit used by Nginx. Sounds like this value was good enough for a lot of Bearer headers with JWT tokens. Closes #13541. (cherry picked from commit b807887) (cherry picked from commit 95d859d)
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the client authenticates, the standard
frame_max is not used. Instead, the initial limit uses a special constant.
This is fine for password or x.509 certificate-based authentication but not for some JWT tokens, which can vary in size, and take multiple kilobytes.
8 kB specifically is the default HTTP header length limit used by Nginx.
Sounds like this value was good enough for a lot of Bearer headers with JWT tokens.
Closes #13541.
This is an automatic backport of pull request #13542 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #13543 done by [Mergify](https://mergify.com).