Upgrading from 3.13.x to 4.x breaks management UI

[lukebakken]

Describe the bug

Upgrading a 3.13.x system to 4.x with your system theme set to dark causes the management UI to cease working.

Reproduction steps

1. Clear your browser cache to start fresh.
2. Enable your system's dark theme (optional)
3. Start RabbitMQ 3.13.x and log into the management UI.
4. Stop RabbitMQ 3.13.x, and start RabbitMQ 4.x.
5. Return to the management UI and refresh/force-refresh it.
6. Once refreshed, the UI ceases to work and the dev tools shows the following error:

   content_script.js:1 content script loaded 38f38f44-a4a1-445f-b3a0-fb06aafaafae
   credentials.js:1 Injecting credentials patch
   sammy-0.7.6.min.js:5 [Wed May 28 2025 10:48:40 GMT-0700 (Pacific Daylight Time)] body Plugin Error: called use() but plugin (Sammy.Title) is not defined Cannot read properties of undefined (reading 'apply') TypeError: Plugin Error: called use() but plugin (Sammy.Title) is not defined Cannot read properties of undefined (reading 'apply')
       at Sammy.Application.use (sammy-0.7.6.min.js:5:7826)
       at Sammy.Application.dispatcher (main.js:77:10)
       at new Sammy.Application (sammy-0.7.6.min.js:5:6748)
       at start_app (main.js:197:11)
       at dispatcher_add (main.js:72:9)
       at dispatcher.js:1:1
   main.js:78 Uncaught TypeError: this.setTitle is not a function
       at Sammy.Application.dispatcher (main.js:78:10)
       at new Sammy.Application (sammy-0.7.6.min.js:5:6748)
       at start_app (main.js:197:11)
       at dispatcher_add (main.js:72:9)
       at dispatcher.js:1:1
   

7. After the above happens, you are unable to do anything in the management UI. Only clearing the cache resolves the issue. Thankfully, that appears to permanently resolve the issue. Running the UI in a private/incognito window also works, presumably because assets are not cached.

Expected behavior

Upgrading from 3.13.x to 4.x does not compromise the behavior of the management UI.

Additional context

Related issues:

• Change browser tab/window title according to currently loaded view (tab) #13512

[lukebakken]

Workaround (in Chrome, at least):

• Load broken management UI
• Open dev tools
• In the Network tab, click Disable cache
• Force-reload

[efimov90]

Are you sure it's dark theme support caused issue? I have seen other changes related to this plugin in changelog

[lukebakken]

Are you sure it's dark theme support caused issue?

You make a good point. I'll keep that in mind if/when I find time to investigate this issue.

[michaelklishin]

@lukebakken it could be the classic asset caching issue that we have (mostly?) addressed only very recently. Just my 2¢.

[lukebakken]

asset caching issue that we have (mostly?) addressed only very recently

Is there a PR or issue I can look at with regard to that?

[michaelklishin]

@lukebakken #12749

[lukebakken]

Unfortunately, #12749 doesn't resolve the issue. Investigating!

[lukebakken]

Ah, possibly introduced by #13512

[lukebakken]

git-bisect narrowed the issue down to this commit: a0abfaa

cc @ikavgo

I'll see if I can fix it.

[ikavgo]

Does this happen only on upgrades from 3.x? or from 4.x too? That cache control PR was backported to 4.0.x so it shouldn't. Maybe the problem can be solved by Release Notes entry?