Skip to content

Make object_usage_linter glue aware #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 21, 2022
Merged

Make object_usage_linter glue aware #969

merged 14 commits into from
Mar 21, 2022

Conversation

AshesITR
Copy link
Collaborator

Fixes #942

LMK if the tests are sufficient.

There are two blacklisted arguments, .envir and .transformer to ensure they are what glue uses by default.
Also, only calls with only STR_CONST expressions are evaluated.

@AshesITR AshesITR requested a review from MichaelChirico March 21, 2022 14:37
@AshesITR AshesITR added this to the 3.0.0 milestone Mar 21, 2022
@AshesITR
Copy link
Collaborator Author

TIL devtools::check() has options(keep.source = FALSE) whereas devtools::test() has options(keep.source = TRUE).

MichaelChirico
MichaelChirico reviewed Mar 21, 2022
View reviewed changes
@MichaelChirico
Copy link
Collaborator

Also remove the #nolints that this solves since there are only a few

@MichaelChirico MichaelChirico merged commit 1e08b13 into master Mar 21, 2022
@MichaelChirico MichaelChirico deleted the feature/object-usage-glue branch March 21, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

object_usage_linter could me made glue-aware
2 participants
@AshesITR @MichaelChirico