-
Notifications
You must be signed in to change notification settings - Fork 193
Add SNAKE_CASE style option #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like to write variables in snake_case except when they are CONSTANTS. To prevent the `object_name_linter` from complaining, I would like to allow (uppercase) "SNAKE_CASE" as an option.
Could you add several tests to ensure this works as anticipated and remake the docs to ensure SNAKE_CASE is added to the help page for It looks like the regex will match "MY_var" but not "DONT_MUTATE_MY_BIG_TABLE" at present. |
Thanks, will do once I have access to a RStudio instance. |
@russHyde It appears that man/ is .gitignored, but locally the docs got updated to include
I had to manually delete man/linters.Rd, though. Roxygen didn't automatically detect the change. |
That's funny. I can't see man/ in the .gitignore for lintr. |
Ah, the .Rd files are actually the same: \item{styles}{A subset of
\Sexpr[stage=render, results=rd]{lintr:::regexes_rd}. A name should
match at least one of these styles.} Anything else needs updating? |
lgtm. recommend merging if that's okay with you @jimhester . |
Merge away! Also feel free to merge other PRs in the future without needing to ping me unless you need an extra set of eyes |
Thanks @AshesITR . |
I like to write variables in snake_case except when they are CONSTANTS.
To prevent the
object_name_linter
from complaining, I would like to allow (uppercase) "SNAKE_CASE" as an option.