'fun' not found

[tristanwietsma]

Transitioning from #25 to narrower scope:

> lint('EngineXLSX.R', with_defaults(line_length_linter(80)))
Error in body(fun) : object 'fun' not found

Source does execute without a hitch.

[tristanwietsma]

and here is the traceback:

> traceback()
12: body(fun)
11: findLocalsList(c(list(body), dropMissings(formals)))
10: codetools::findFuncLocals(formals(fun), body(fun))
9: FUN(9L[[1L]], ...)
8: lapply(ids_with_token(source_file, rex(start, "FUNCTION"), fun = re_matches), 
       function(loc) {
           id <- source_file$parsed_content$id[loc]
           parent_ids <- parents(source_file$parsed_content, id, 
               simplify = FALSE)
           if (length(parent_ids) > 3L) {
               return(NULL)
           }
           text <- paste0(collapse = "\n", source_file$lines)
           try(fun <- eval(parse(text = text, keep.source = TRUE), 
               envir = env), silent = TRUE)
           res <- parse_check_usage(fun)
           locals <- codetools::findFuncLocals(formals(fun), body(fun))
           both <- c(locals, names(formals(fun)), all_globals)
           lapply(which(!is.na(res$message)), function(row_num) {
               row <- res[row_num, ]
               if (re_matches(row$message, rex("no visible"))) {
                   suggestion <- both[stringdist::amatch(row$name, 
                     both, maxDist = 2)]
                   if (!is.na(suggestion)) {
                     row$message <- paste0(row$message, ", Did you mean '", 
                       suggestion, "'?")
                   }
               }
               org_line_num <- as.integer(row$line_number) + as.integer(names(source_file$lines)[1]) - 
                   1L
               line <- source_file$lines[as.character(org_line_num)]
               row$name <- re_substitutes(row$name, rex("<-"), "")
               location <- re_matches(line, rex(row$name), locations = TRUE)
               Lint(filename = source_file$filename, line_number = org_line_num, 
                   column_number = location$start, type = "warning", 
                   message = row$message, line = line, ranges = list(c(location$start, 
                     location$end)))
           })
       })
7: linters[[linter]](expr)
6: inherits(x, class)
5: assign_item(x)
4: flatten_list(x, class = "lint")
3: structure(flatten_list(x, class = "lint"), class = "lints")
2: flatten_lints(linters[[linter]](expr))
1: lint("EngineXLSX.R", with_defaults(line_length_linter(80)))

[jimhester]

@tristanwietsma sorry I haven't gotten to the bottom of this yet, probably just need to tweak the try(fun <- eval(parse(text = text, keep.source = TRUE), envir = env), silent = TRUE) logic only execute the subsequent lines if the eval line succeeds.

[tristanwietsma]

thanks. let me know if you need me to test a branch.

[Hampei]

I'm running into this as well.
Can't use the linter because of it. Anyone found a solution/workaround?

[etheleon]

+1