Skip to content

path should be converted to UTF8 first in path_tidy() #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2021
Merged

path should be converted to UTF8 first in path_tidy() #322

merged 3 commits into from
Apr 8, 2021

Conversation

shrektan
Copy link
Contributor

@shrektan shrektan commented Apr 7, 2021

Fix #321

jimhester
jimhester reviewed Apr 7, 2021
View reviewed changes
NEWS.md Outdated
@@ -8,6 +8,8 @@

* fs is now licensed as MIT (#301).

* `path_tidy()` now works with non-UTF8 encoded paths (#321).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add your GitHub username here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@jimhester jimhester merged commit 4cc4b56 into r-lib:master Apr 8, 2021
@jimhester
Copy link
Member

Thank you!

@shrektan shrektan deleted the fix321 branch April 8, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimhester jimhester jimhester left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path_tidy() doesn't work with non-UTF8 path
2 participants
@shrektan @jimhester