perf: add max udp payload size option - #2343
Merged
Merged
Conversation
Dreamacro
force-pushed
the
perf-max-udp-payload-size
branch
from
August 24, 2025 14:42
72ba69d to
4696afd
Compare
Contributor
Author
|
@djc already rebase main |
Dreamacro
force-pushed
the
perf-max-udp-payload-size
branch
from
August 24, 2025 14:45
4696afd to
c30ebaf
Compare
Dreamacro
changed the title
Member
|
(I'd like @Ralith to take a look before merging.) |
Ralith
approved these changes
Aug 25, 2025
Ralith
left a comment
Ralith
left a comment
Collaborator
There was a problem hiding this comment.
There's a case for Option<u16> so that we only have to write the default value in one spot, but I like how, as written, the default shows up gracefully in the auto-generated CLI flag documentation.
Collaborator
|
Using the interface MTU by default would also be a nice idea, but the question of which interface MTU becomes very hairy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the actual MTU of the interface is not 1500, so I would like perf to customize this.
I noticed that #2342 also makes changes to perf, so I can wait until it's merged and adjust the code.