Skip to content

Use the correct MTU for prev_path - #1776

Merged
Ralith merged 1 commit into
quinn-rs:mainfrom
nemethf:prev_path
Apr 2, 2024
Merged

Use the correct MTU for prev_path#1776
Ralith merged 1 commit into
quinn-rs:mainfrom
nemethf:prev_path

Conversation

@nemethf

@nemethf nemethf commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

I've just bumped into this. I'm not confident this is really a bug, but using the MTU of a different path seems a wrong thing to do.

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to make more sense, thanks for pointing it out!

Comment thread quinn-proto/src/connection/mod.rs Outdated
@djc

djc commented Mar 26, 2024

Copy link
Copy Markdown
Member

@nemethf did you want to follow up on this?

@nemethf

nemethf commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

@nemethf did you want to follow up on this?

Should I update the PR with reserve(MIN_INITIAL_SIZE)? (I'm okay with @Ralith or you do it.)

@djc

djc commented Mar 27, 2024

Copy link
Copy Markdown
Member

@nemethf did you want to follow up on this?

Should I update the PR with reserve(MIN_INITIAL_SIZE)? (I'm okay with @Ralith or you do it.)

Would be nice!

Co-Authored-By: Benjamin Saunders <ben.e.saunders@gmail.com>
@nemethf

nemethf commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

@nemethf did you want to follow up on this?

I force-pushed a version suggested by @Ralith. Thanks.

@Ralith Ralith left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith
Ralith merged commit f879a35 into quinn-rs:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants