Skip to content

silent an info message related to ack frequency. - #1652

Merged
Ralith merged 2 commits into
quinn-rs:mainfrom
stormshield-damiend:silent_info_ack_freq_rtt
Aug 31, 2023
Merged

silent an info message related to ack frequency.#1652
Ralith merged 2 commits into
quinn-rs:mainfrom
stormshield-damiend:silent_info_ack_freq_rtt

Conversation

@stormshield-damiend

Copy link
Copy Markdown
Contributor

Change an info into debug to silent a message that show too frequently.

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe "silent" -> "Silence" in the commit message?

Thanks!

@Ralith Ralith left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this definitely wasn't intended. We should probably even drop it further -- debug isn't intended to have a lot of routine noise.

Comment thread quinn-proto/src/connection/mod.rs Outdated
@Ralith
Ralith enabled auto-merge (squash) August 31, 2023 17:29
@Ralith
Ralith merged commit a516c2b into quinn-rs:main Aug 31, 2023
@stormshield-damiend
stormshield-damiend deleted the silent_info_ack_freq_rtt branch September 1, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants