Clippy fixes - #1466
Merged
Merged
Conversation
The lint issue that made the workaround necessary has been resolved.
Contributor
Author
|
No worries!
I thought size_t was platform specific, but I looked it up earlier, and it's defined unconditionally as a type alias for usize, so maybe it would make sense to remove these annotations and the cast. |
Collaborator
|
Try it and see what CI thinks? |
StygianLightning
force-pushed
the
clippy-fixes
branch
from
December 8, 2022 19:50
5414388 to
775cf67
Compare
djc
previously approved these changes
Dec 9, 2022
Contributor
Author
|
Huh, Mac doesn't like that for some reason. Gonna fix it tonight. |
StygianLightning
force-pushed
the
clippy-fixes
branch
from
December 10, 2022 00:21
775cf67 to
c7f0cf9
Compare
Contributor
Author
|
I fixed the three instances that failed on macOS and reduced the scope of the two #[allow] annotations from my original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked the examples and found a typo in one of the examples and an allowed lint as a workaround to a bug that's since been fixed. The other commits fix some clippy lints that show up on nightly.