rather than importing futures only import the crates we really need. … - #1175
Merged
Conversation
…This way we can streamline our dependencies, e.g. futures-executor is not used at all
djc
previously approved these changes
Aug 10, 2021
Member
|
Thanks, this looks good! |
Member
|
Looks like CI is not quite happy. Maybe it would also make sense to import items from core via util, so we need to maintain one less direct import? |
Contributor
Author
|
fixed tests, benches |
xMAC94x
force-pushed
the
xMAC94x/use_future_subscrates
branch
from
August 10, 2021 17:02
d09f666 to
9a17af3
Compare
Ralith
previously approved these changes
Aug 10, 2021
Ralith
left a comment
Ralith
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Eventually I'd like to drop these entirely as they're kind of heavy; this is a good first step.
xMAC94x
force-pushed
the
xMAC94x/use_future_subscrates
branch
from
August 10, 2021 18:25
9a17af3 to
f4f3892
Compare
Ralith
previously requested changes
Aug 10, 2021
…isntead of futures_core
xMAC94x
force-pushed
the
xMAC94x/use_future_subscrates
branch
from
August 11, 2021 07:51
f4f3892 to
ae531ca
Compare
djc
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…This way we can streamline our dependencies, e.g. futures-executor is not used at all
Additionally i updated the dependencies to futures 0.3.11, as 0.3.8 is yanked (same for 0.3.9 and 0.3.10)