Drop outgoing packets on permission errors - #1157
Merged
Merged
Conversation
Ralith
previously approved these changes
Jul 8, 2021
Matthias247
force-pushed
the
perm
branch
2 times, most recently
from
July 8, 2021 01:48
2c4cb15 to
355ae13
Compare
When packets failed to transmit - e.g. due to being blocked by iptables - the quinn endpoint kept them around and tried to retransmit them later on. This usually failed for the same reason, which resulted in an infinitely growing list of packets to transmit. To prevent this, this change drops all packets where sending fails for a a non-fatal reason.
Ralith
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packets failed to transmit - e.g. due to being blocked by iptables - the
quinn endpoint kept them around and tried to retransmit them later on. This
usually failed for the same reason, which resulted in an infinitely growing list
of packets to transmit.
To prevent this, this change drops all packets where sending fails for a
a non-fatal reason.