fix: check for running VM processes using kill -0#182
Merged
flexiondotorg merged 1 commit intomainfrom Jul 3, 2024
Merged
Conversation
ymauray
approved these changes
Jul 3, 2024
Member
ymauray
left a comment
ymauray
left a comment
There was a problem hiding this comment.
Looks good to me ! The "stop" button is active when the VM is running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change how VM processes are inspected to test if they are running but using
kill -0 <pid>. Usekill -0is portable between macOS and Linux and the BSD and GNU tools.quickemualso useskill -0, which was introduced as part of the macOS porting work.I've tested this on Linux to make sure there are no regressions; it needs validating on macOS.
Type of change
Checklist: