Skip to content

fix: localizations#177

Merged
flexiondotorg merged 1 commit intomainfrom
fix/localizations
Jul 2, 2024
Merged

fix: localizations#177
flexiondotorg merged 1 commit intomainfrom
fix/localizations

Conversation

@ymauray
Copy link
Copy Markdown
Member

@ymauray ymauray commented Jul 1, 2024

Description

A whitespace has been added to a localizable message in the code, but the .po files have not been updated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions

@flexiondotorg
Copy link
Copy Markdown
Member

flexiondotorg commented Jul 1, 2024

What do you run to update the .po files? I can investigate putting something in CI to get them up to date 🙂

@ymauray
Copy link
Copy Markdown
Member Author

ymauray commented Jul 1, 2024

There is no automated process for that. And I have no clue how to put one in place.
The best course of action is to not touch the text in "context.t("Blah")", as this is the key that is used to fetch the messages in the .po files.
It might be worth investigating how to look at the code for calls to context.t
Maybe a code generator?

@flexiondotorg
Copy link
Copy Markdown
Member

So how did all those .po files get updated exactly?

@ymauray
Copy link
Copy Markdown
Member Author

ymauray commented Jul 1, 2024

I updated them all by hand.

@ymauray
Copy link
Copy Markdown
Member Author

ymauray commented Jul 1, 2024

I think in debug mode, an exception should be thrown if a message is not found in the current language file (probably english, or french). Therefore, the developper would have to add the message at least one .po file, and hopefully, think about adding it to quickgui.pot

@ymauray
Copy link
Copy Markdown
Member Author

ymauray commented Jul 1, 2024

By the way, currently, when a message is not found, it is displayed in the console.

@flexiondotorg flexiondotorg merged commit 275d065 into main Jul 2, 2024
@flexiondotorg flexiondotorg deleted the fix/localizations branch July 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants