quic-teec: update the find way of the QCBOR #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the compilation issue that cannot find the libqcbor.a. The root cause is that the QCBOR include path has changed. Signed-off-by: Jiaxing Li <[email protected]>
Contributor
|
Hi @jiaxli-QC, are you observing this compilation issue with QCBOR repo tip? |
Contributor
Author
|
Yes, That's right. The FindQCBOR.cmake cannot locate the libraries and headers because the PATH_SUFFIXES value is incorrect. |
Contributor
|
@jiaxli-QC, I cloned the tip of the QCBOR project and checked if somehow build is broken because of this. But I was able to build fine without any issues, in fact the paths remained unchanged for me. I am building with BUILD_SHARED_LIBS=ON flag, but I remember that building a static library without that flag also didn't cause any issues. Can you point me to any commit on the QCBOR repo where this installation path change has been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the compilation issue that cannot find the libqcbor.a. The root cause is that the QCBOR include path has changed.