Mem object #15
Merged
Mem object #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some shared symbols from qcomte_object.c. Move tee_call_t refernce to the root object to keep life easier. Signed-off-by: Amirreza Zarrabi <[email protected]>
Update based on commit 9c20f36. Signed-off-by: Amirreza Zarrabi <[email protected]>
Rename some symbols for consistency. Signed-off-by: Amirreza Zarrabi <[email protected]>
The return values was not handelled. Also, some cleanups for namespace codes. Signed-off-by: Amirreza Zarrabi <[email protected]>
Signed-off-by: Amirreza Zarrabi <[email protected]>
qc-azarrabi
force-pushed
the
mem-object
branch
6 times, most recently
from
562e578 to
bf549f7
Compare
| set(SRC | ||
| src/qcomtee_object.c | ||
| src/objects/credentials_obj.c | ||
| src/objects/mem_obj.c |
libqcomtee/src/objects/mem_obj.c
Outdated
| #include <qcomtee_object_private.h> | ||
|
|
||
| /* MEMORY Object. */ | ||
| struct qcomtee_memmory { |
Contributor
There was a problem hiding this comment.
Typo? qcomtee_memory?
libqcomtee/src/objects/mem_obj.c
Outdated
| #include <qcomtee_object_private.h> | ||
|
|
||
| /* MEMORY Object. */ | ||
| /* Which TEE API was used to prepare the meory object: */ |
Contributor
There was a problem hiding this comment.
Typo, 'memory object'.
libqcomtee/src/qcomtee_object.c
Outdated
|
|
||
| /* Simple id allocator. */ | ||
| for (i = 0; i < TABLE_SIZE; i++) { | ||
| if (idx == 0) |
Contributor
There was a problem hiding this comment.
Comparing possibly uninitialized idx here is giving a compilation error..
qc-azarrabi
force-pushed
the
mem-object
branch
4 times, most recently
from
58c3722 to
3d78ec3
Compare
harshaldev27
approved these changes
Mar 23, 2025
Contributor
harshaldev27
left a comment
harshaldev27
left a comment
There was a problem hiding this comment.
This commit looks good to me.
harshaldev27
approved these changes
Mar 23, 2025
Contributor
harshaldev27
left a comment
harshaldev27
left a comment
There was a problem hiding this comment.
This commit looks good to me.
Contributor
harshaldev27
left a comment
harshaldev27
left a comment
There was a problem hiding this comment.
This looks good to me.
Contributor
harshaldev27
left a comment
harshaldev27
left a comment
There was a problem hiding this comment.
This commit looks good to me.
Contributor
harshaldev27
left a comment
harshaldev27
left a comment
There was a problem hiding this comment.
This commit looks good to me.
- Add new object ID. This is the ID seen by QTEE. The original object_id is the ID visibale locally. - Improve ns table to accept type to search for tee_object_id. Signed-off-by: Amirreza Zarrabi <[email protected]>
Introduce these APIs: - qcomtee_memory_object_alloc to create a new memory object. - qcomtee_memory_object_addr to get address of memory object. - qcomtee_memory_object_size to get size of memory object. - qcomtee_memory_object_release to release the meory object. Signed-off-by: Amirreza Zarrabi <[email protected]>
Signed-off-by: Amirreza Zarrabi <[email protected]>
Run unittest path_to_bin 0 cmd [use buffer] Run unittest path_to_bin 1 cmd [use memory object] Signed-off-by: Amirreza Zarrabi <[email protected]>
Signed-off-by: Amirreza Zarrabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commit to prepare for memory object, including: