Skip to content

Update the library #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update the library #20

wants to merge 13 commits into from

Conversation

adrpo
Copy link

@adrpo adrpo commented Aug 16, 2023 •
edited
Loading

  • fix the cardinality handling
  • fix the way specificEnthalpy_pT and specificEnthalpy_pTX was handled (specificEnthalpy_pT calls specificEnthalpy_pTX with fill(0, 0) but it should be fill(0, 1) because the third argument is default bound to reference_X
  • the DymolaCommands library was not even used, I removed the dependency
  • update the library to be able to use MSL to 4.0.0

With these changes the Example models compile with OpenModelica but they fail to initialize (hopefully I can fix this too but I'm not a modeler so any help would be appreciated)

This was referenced Aug 16, 2023
Open
Open
Open
Open
@adrpo
get the example models to simulate with Dymola
845525e 
- by removing the conflicting start values

the models do not work yet in OpenModelica
they still have issues at initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrpo