Merged
Conversation
This is not the final implementation as it doesn't handle some tricky combinations like joystick movements that emulate a D-pad. It also ignores the taps as they're activated at the moment the gesture is finished (i.e. the finger is detached from a screen). Right now we can handle gamepad, keyboard and mouse key release events. Key modifiers work too and it's not necessary to release the modifier keys during the same frame as the main key. So, a `ctrl+lmb` released event would trigger if `lmb` is released while `ctrl` is still being pressed. A new example demonstrates how to use this new feature. It also demonstrates how to avoid some of the conflicts described in #36 (this is not a novel issue and it's not related to the release events directly). Refs #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the final implementation as it doesn't handle some tricky combinations like joystick movements that emulate a D-pad.
It also ignores the taps as they're activated at the moment the gesture is finished (i.e. the finger is detached from a screen).
Right now we can handle gamepad, keyboard and mouse key release events.
Key modifiers work too and it's not necessary to release the modifier keys during the same frame as the main key.
So, a
ctrl+lmbreleased event would trigger iflmbis released whilectrlis still being pressed.A new example demonstrates how to use this new feature. It also demonstrates how to avoid some of the conflicts described in #36 (this is not a novel issue and it's not related to the release events directly).
Refs #25