Add press duration to PressedActionInfo#33
Merged
quasilyte merged 3 commits intoquasilyte:masterfrom Nov 1, 2023
Merged
Conversation
Owner
|
I'll take a closer look tomorrow, but I think it looks good. |
…me length in ticks as inpututil.KeyPressDuration
Contributor
Author
|
Sure, no worries. Let me know if changes are needed or if there are improvements that should be made. |
quasilyte
approved these changes
Nov 1, 2023
Owner
|
We may want to add something that uses this feature in the examples though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add key press duration to the
PressedActionInfo's EventInfo.Resolves #32
I've included an internal
minOfimplementation. This can be removed if the required go version can be bumped to 1.21.0+ which has a built-inminfunction with variadic parameter support.