Avoid creating too many ReflectiveClassBuildItem when possible

[metacosm]

Also avoid roundtripping between array and list when adding classes.

[quarkus-bot]

/cc @brunobat (micrometer), @ebullient (micrometer), @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search)

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 0a46e1e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[github-actions]

🎊 PR Preview eb8faf5 has been successfully built and deployed to https://quarkus-pr-main-51672-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0a46e1e.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
❌	Native Tests - Data5	Build	Failures	Logs	Raw logs	🔍
❌	JVM Integration Tests - JDK 17	Build	Failures	Logs	Raw logs	🔍
❌	JVM Integration Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs	🔍
❌	JVM Integration Tests - JDK 21	Build	Failures	Logs	Raw logs	🔍
❌	JVM Integration Tests - JDK 21 Semeru	Build	Failures	Logs	Raw logs	🔍
❌	JVM Integration Tests - JDK 25	Build	Failures	Logs	Raw logs	🔍

You can consult the Develocity build scans.

Failures

⚙️ Native Tests - Data5 #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-jpa-postgresql-withxml: Failed to build quarkus application

---

⚙️ JVM Integration Tests - JDK 17 #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-integration-test-jpa-postgresql-withxml:

See /home/runner/_work/quarkus/quarkus/integration-tests/jpa-postgresql-withxml/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

---

⚙️ JVM Integration Tests - JDK 17 Windows #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-jpa-postgresql-withxml: Failed to build quarkus application

---

⚙️ JVM Integration Tests - JDK 21 #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-integration-test-jpa-postgresql-withxml:

See /home/runner/_work/quarkus/quarkus/integration-tests/jpa-postgresql-withxml/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

---

⚙️ JVM Integration Tests - JDK 21 Semeru #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-integration-test-jpa-postgresql-withxml:

See /home/runner/_work/quarkus/quarkus/integration-tests/jpa-postgresql-withxml/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

---

⚙️ JVM Integration Tests - JDK 25 #

- Failing: integration-tests/jpa-postgresql-withxml 

📦 integration-tests/jpa-postgresql-withxml

❌ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-integration-test-jpa-postgresql-withxml:

See /home/runner/_work/quarkus/quarkus/integration-tests/jpa-postgresql-withxml/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21 Semeru

📦 extensions/micrometer-opentelemetry/deployment

❌ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

• Stream has no elements - java.lang.IllegalArgumentException

Details

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:214)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:214)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:232)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:149)

---

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

❌ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

• Stream has no elements - java.lang.IllegalArgumentException

Details

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:214)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:214)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:232)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:173)

[lucamolteni]

@metacosm I quickly skimmed the hibernate part but to me is not entirely clear whether this is a refactor or it does change the logic can you clarify?

[gsmet]

Yeah, I agree we need to clarify the intent, given CI is not happy about it, it's not that obvious that the changes are trivial and not risky so we need to know why we want them.

[metacosm]

Agreed, this is something I started pulling on while working on the Kubernetes client and maybe got a little carried away as I kept on pulling… I will look at CI when I come back from PTO.

The idea behind this change is two-fold:

1. there are lots of ReflectiveClassBuildItem being created, most of the time before the capability of passing a list of items to the build item was added (I surmise) so I thought, why not replace creating single BIs by using list of items instead when possible… this is a tricky refactor in the sense that you need to make sure that what you're replacing is actually equivalent and I might have missed some calls
2. internally, ReflectiveClassBuildItem was using a list, when there didn't seem any obvious (but maybe I'm mistaken here) need to do so. I thought that making it possible to pass a collection of items instead of array-like would avoid unneeded round-trips between collections and arrays: there are several spots in the code where the needed information was already available but in the form of a Set, for example, which was converted to an array for the BI constructor, then back to a List so the idea there was to remove that conversion step where possible / it made sense… One aspect that's not clear to me is whether converting a Stream to an array or a List is better, though I suspect that toArray might be more efficient since the default implementation of toList actually calls toArray…

Converting this back to draft so that I can double check my work, was maybe too eager to finish this on Friday night before my PTOs! 😅