-
Notifications
You must be signed in to change notification settings - Fork 3k
Update Smallrye Config to 3.15.0 #51671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
366f87a to
410c177
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 9dfee3f has been successfully built and deployed to https://quarkus-pr-main-51671-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
...s/devui/deployment/src/main/java/io/quarkus/devui/deployment/menu/DependenciesProcessor.java
Outdated
Show resolved
Hide resolved
| @ConfigDocIgnore | ||
| @WithParentName | ||
| Map<String, String> channelConfig(); | ||
| Map<String, Optional<String>> channelConfig(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When can this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is to resolve:
- In Quarkus Messaging missing required fields fail deploy when channel is disabled #51501
- mp.messaging creating unrecognized configuration key #51556
Usually, in our configuration for named groups, we map every possible name, where each name is either required or optional (take, for instance, the JDBC configuration). In the case of the RM config, the named clients' configuration depends on the value of the connector, meaning that effectively any name in the channelConfig is optional.
A Map<String, String>, makes the value required if a key is found, so for this case, it must be a Map<String, Optional>. This kind of mapping was not implemented in SR Config, and I've added it for this use case.
…loyment/menu/DependenciesProcessor.java Co-authored-by: George Gastaldi <[email protected]>
Status for workflow
|
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🔍 | ||
| ❌ | JVM Tests - JDK 21 Semeru | Build |
Failures | Logs | Raw logs | 🔍 |
| ✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 17 Windows | Logs | Raw logs | 🔍 | ||
| ❌ | JVM Integration Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✔️ | JVM Integration Tests - JDK 21 Semeru | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 25 | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 21 Semeru #
- Failing: extensions/panache/hibernate-orm-panache-kotlin/runtime
! Skipped: devtools/bom-descriptor-json extensions/panache/hibernate-orm-panache-kotlin/deployment 📦 extensions/panache/hibernate-orm-panache-kotlin/runtime
❌ Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:2.3.0:compile (compile) on project quarkus-hibernate-orm-panache-kotlin: Compilation failure
⚙️ JVM Integration Tests - JDK 21 #
- Failing: integration-tests/spring-web
📦 integration-tests/spring-web
❌ io.quarkus.it.spring.web.SpringSchedulerTest.testCount line 22 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:69)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:41)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:195)
at io.quarkus.it.spring.web.SpringSchedulerTest.testCount(SpringSchedulerTest.java:22)
Flaky tests - Develocity
⚙️ JVM Tests - JDK 25
📦 extensions/smallrye-reactive-messaging/deployment
❌ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History
Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"]-java.lang.AssertionError
Details
java.lang.AssertionError:
Expecting actual:
["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
["-6", "-7", "-8", "-9"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)
⚙️ JVM Integration Tests - JDK 17
📦 integration-tests/mailer
❌ io.quarkus.it.mailer.MailerTest.sendHtmlEmail - History
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException-java.lang.RuntimeException
Details
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:668)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:763)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at io.quarkus.test.junit.TestResourceUtil$TestResourceManagerReflections.startReflectively(TestResourceUtil.java:217)
📦 integration-tests/oidc-wiremock
❌ io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken - History
expected: <true> but was: <false>-org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:69)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:41)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:195)
at io.quarkus.it.keycloak.CodeFlowAuthorizationTest.testCodeFlowUserInfoCachedInIdToken(CodeFlowAuthorizationTest.java:431)
⚙️ JVM Integration Tests - JDK 21
📦 integration-tests/virtual-threads/grpc-virtual-threads
❌ io.quarkus.grpc.example.streaming.VirtualThreadTest.testGrpcClient - History
1 expectation failed. Expected status code <200> but was <500>.-java.lang.AssertionError
Details
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:60)

SmallRye Config Release notes:
Quarkus: