-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix OTel MDC context set #51641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTel MDC context set #51641
Conversation
|
/cc @ebullient (micrometer), @radcortez (opentelemetry) |
a1b9114 to
890a77a
Compare
This comment has been minimized.
This comment has been minimized.
.../opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/OpenTelemetryUtil.java
Outdated
Show resolved
Hide resolved
.../opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/OpenTelemetryUtil.java
Outdated
Show resolved
Hide resolved
...ntelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/QuarkusContextStorage.java
Outdated
Show resolved
Hide resolved
...ntelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/QuarkusContextStorage.java
Outdated
Show resolved
Hide resolved
geoand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
I only added some trivial comments
|
@geoand I was commenting here: #49630 (comment) |
890a77a to
0f0e867
Compare
This comment has been minimized.
This comment has been minimized.
geoand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Status for workflow
|
|
Failures seem unrelated. Will merge. |
|
@gsmet We should consider this to backport, if possible. |
There are 2 fixes here:
Did some refactoring to clarify context objects because we have too many types of contexts.
Added some debug logs for future debugging.