Skip to content

Ignore an additional flaky OpenTelemetry metric for Semeru #51296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brunobat merged 1 commit into from
Nov 28, 2025
Merged

Ignore an additional flaky OpenTelemetry metric for Semeru #51296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions integration-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ void testAllJvmMetrics() {
.containsAll(allMetrics.stream().map(MetricToAssert::name).toList());
});

Set<String> flakyMetrics = new HashSet<>();
flakyMetrics.add("jvm.memory.used_after_last_gc");
flakyMetrics.add("jvm.cpu.limit");
flakyMetrics.add("jvm.cpu.recent_utilization");
flakyMetrics.add("jvm.system.cpu.utilization");
if (JdkUtil.isSemeru()) {
// this one has been flaky on CI with Semeru
flakyMetrics.add("jvm.memory.used");
}

allMetrics.forEach(metricToAssert -> {

// metric is there and has at least 1 reading
Expand All @@ -113,11 +123,7 @@ void testAllJvmMetrics() {
.hasSizeGreaterThan(0));

// skip assertions from flaky metrics
if (!metricToAssert.name().equals("jvm.memory.used_after_last_gc") &&
!metricToAssert.name().equals("jvm.cpu.limit") &&
!metricToAssert.name().equals("jvm.cpu.recent_utilization") &&
!metricToAssert.name().equals("jvm.system.cpu.utilization")) {

if (!flakyMetrics.contains(metricToAssert.name())) {
// Correct values might take some time to register
await().atMost(10, SECONDS).untilAsserted(() -> assertThat(getLastReading(metricToAssert))
.withFailMessage("Metric must be greater than 0: " + metricToAssert.name)
Expand Down
Loading