Update documentation for handling proxies in native-mode#45004
Update documentation for handling proxies in native-mode#45004gsmet merged 1 commit intoquarkusio:mainfrom
Conversation
gsmet
left a comment
There was a problem hiding this comment.
I spotted a small typo.
I'm not sure I'm completely sold about merging the two sections given how this document has been built (and given these are two very different scopes). But happy to be proven wrong if you have a strong opinion about it :)
| ---- | ||
|
|
||
| Using such a construct means that a `-H:DynamicProxyConfigurationResources` option will automatically be added to the `native-image` command line. | ||
| This will allow Quarkus to generate the necessary configurtion for handling the proxy class. |
There was a problem hiding this comment.
| This will allow Quarkus to generate the necessary configurtion for handling the proxy class. | |
| This will allow Quarkus to generate the necessary configuration for handling the proxy class. |
There was a problem hiding this comment.
Nice catch! You have eagle eyes :)
| Using such a construct means that a `-H:DynamicProxyConfigurationResources` option will automatically be added to the `native-image` command line. | ||
| This will allow Quarkus to generate the necessary configurtion for handling the proxy class. | ||
| Alternatively, you may create a `proxy-config.json` file under the `src/main/resources/META-INF/native-image/<group-id>/<artifact-id>` folder. | ||
| For more information about the format of this file, see the link:https://www.graalvm.org/{graalvm-docs-version}/reference-manual/native-image/metadata/#dynamic-proxy-metadata-in-json[Dynamic Proxy Metadata in JSON] documentation. |
There was a problem hiding this comment.
FWIW, you don't need the link: when it's a URL starting with https?://
There was a problem hiding this comment.
I just followed the existing pattern (it's easier than visiting the docs :) )
Removed
There was a problem hiding this comment.
Oh yeah, it was more for the future, no worries.
* Merge "Managing Proxy Classes" sections. * Remove outdated mention to `-H:DynamicProxyConfigurationResources` Quarkus no longer uses `-H:DynamicProxyConfigurationResources` for dynamic proxies. Instead it generates the corresponding necessary metadata in `META-INF/native-image/proxy-config.json`
733b819 to
c09ade9
Compare
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
Oh, I never commented on that but it looks like you went ahead with it anyway. |
|
Yeah, I understand the thing about duplication but in this case, things are a bit rather different between extensions and apps. If you can add a pointer, that would be perfect. |
Follow up to quarkusio#45004 (cherry picked from commit 036cc7f)
-H:DynamicProxyConfigurationResourcesQuarkus no longer uses
-H:DynamicProxyConfigurationResourcesfordynamic proxies. Instead it generates the corresponding necessary
metadata in
META-INF/native-image/proxy-config.json