Skip to content

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented Oct 26, 2020

Conservatively fixes #10420

Reverts #12961

See #12961

@gsmet
Copy link
Member Author

gsmet commented Oct 26, 2020

/cc @Sanne this is where the 15 MB penalty comes from.

@Sanne
Copy link
Member

Sanne commented Oct 26, 2020

wow that's a lot of space. Wondering if someone would want to explore the reason? cc/ @galderz @n1hility

@gsmet
Copy link
Member Author

gsmet commented Oct 26, 2020

Well, it's just because it includes A TON of classes and then you have all the counterpart classes used to register reflection for each class.

FTR, that's 522 more classes just for Caffeine and then you must have approximately the same number of classes for reflection registration.

@Sanne
Copy link
Member

Sanne commented Oct 26, 2020

yes I understand but they are all rather simple simple / very similar. Ok I probably overreacted as I guess it might be reasonable and not too interesting - it just sounds a bit much for the code it is.

@gsmet gsmet merged commit 569016c into quarkusio:master Oct 27, 2020
@gsmet gsmet modified the milestones: 1.10 - master, 1.9.1.Final Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Caffeine error at runtime when using native build

2 participants