Provide helpful error-message for BindException on quarkus.http.port #12683

xumk · 2020-10-13T13:00:07Z

Fixes #4890

xumk · 2020-10-13T13:01:05Z

@geoand @gastaldi review please

gastaldi

LGTM

core/deployment/src/main/java/io/quarkus/deployment/dev/IsolatedDevModeMain.java

gastaldi · 2020-10-13T14:05:37Z

The commits need to be squashed into a single one here

Dismissing my review since I'm not sure if System.exit needs to be called here

xumk · 2020-10-13T14:30:22Z

@geoand @gastaldi I fixed this

geoand

Thanks!

gastaldi · 2020-10-13T16:42:14Z

This only works with mvn quarkus:dev. I was expecting it to work with java -jar and this is the output:

/tmp/greeting-quarkus ᐅ java -jar target/greeting-quarkus-0.1.0-runner.jar
__  ____  __  _____   ___  __ ____  ______ 
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
2020-10-13 13:41:18,229 ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:609)
	at io.quarkus.runtime.Application.start(Application.java:90)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:93)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:62)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:38)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:104)
	at io.quarkus.runner.GeneratedMain.main(GeneratedMain.zig:29)
Caused by: java.lang.RuntimeException: Unable to start HTTP server
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.doServerStart(VertxHttpRecorder.java:501)
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.startServer(VertxHttpRecorder.java:224)
	at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket-2064782366.deploy_0(VertxHttpProcessor$openSocket-2064782366.zig:136)
	at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket-2064782366.deploy(VertxHttpProcessor$openSocket-2064782366.zig:40)
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:543)
	... 6 more
Caused by: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999)
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.doServerStart(VertxHttpRecorder.java:467)
	... 10 more
Caused by: java.net.BindException: Address already in use
	at java.base/sun.nio.ch.Net.bind0(Native Method)
	at java.base/sun.nio.ch.Net.bind(Net.java:455)
	at java.base/sun.nio.ch.Net.bind(Net.java:447)
	at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:227)
	at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
	at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
	at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
	at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
	at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)
	at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248)
	at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasksFrom(SingleThreadEventExecutor.java:428)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:377)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:488)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:834)

gsmet · 2020-10-13T17:16:40Z

Given it only updates IsolatedDevModeMain, that was a bit expected :)

geoand · 2020-10-13T17:37:55Z

Dev mode is where would normally encounter this error anyway

xumk · 2020-10-14T07:34:33Z

@gastaldi I thought this task #4890 only dev mode. Add this messages for java -jar its PR or create new PR?

gastaldi · 2020-10-14T16:37:41Z

It seems that still needs some adjustments. Here is the output of mvn quarkus:dev when another process is running in 8080 already:

/tmp/greeting-quarkus ᐅ mvn quarkus:dev                                    
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< micro.apps:greeting-quarkus >---------------------
[INFO] Building greeting-quarkus 0.1.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- quarkus-maven-plugin:999-SNAPSHOT:dev (default-cli) @ greeting-quarkus ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /tmp/greeting-quarkus/target/classes
Listening for transport dt_socket at address: 5005
__  ____  __  _____   ___  __ ____  ______ 
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
2020-10-14 13:35:22,316 ERROR [io.qua.run.Application] (Quarkus Main Thread) Port 8080 seems to be in use by another process. Quarkus may already be running or the port is used by another application.
2020-10-14 13:35:22,317 INFO  [io.qua.run.Application] (Quarkus Main Thread) Use 'netstat -anop | grep 8080' to identify the process occupying the port.
2020-10-14 13:35:22,318 INFO  [io.qua.run.Application] (Quarkus Main Thread) You can try to kill it with 'kill -9 <pid>'.
Quarkus application exited with code 1
Press Enter to restart or Ctrl + C to quit

Restarting...
__  ____  __  _____   ___  __ ____  ______ 
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
2020-10-14 13:35:27,425 ERROR [io.qua.run.Application] (Quarkus Main Thread) Port 8080 seems to be in use by another process. Quarkus may already be running or the port is used by another application.
2020-10-14 13:35:27,426 INFO  [io.qua.run.Application] (Quarkus Main Thread) Use 'netstat -anop | grep 8080' to identify the process occupying the port.
2020-10-14 13:35:27,426 INFO  [io.qua.run.Application] (Quarkus Main Thread) You can try to kill it with 'kill -9 <pid>'.
2020-10-14 13:35:27,425 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (Quarkus Main Thread) Failed to start quarkus: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:51)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:145)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:181)
	at io.quarkus.deployment.dev.IsolatedDevModeMain$1.accept(IsolatedDevModeMain.java:99)
	at io.quarkus.deployment.dev.IsolatedDevModeMain$1.accept(IsolatedDevModeMain.java:81)
	at io.quarkus.runtime.ApplicationLifecycleManager.lambda$setDefaultExitCodeHandler$0(ApplicationLifecycleManager.java:271)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:175)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:62)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:38)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:104)
	at io.quarkus.runner.GeneratedMain.main(GeneratedMain.zig:29)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl$3.run(StartupActionImpl.java:134)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:675)
	at io.quarkus.runtime.Application.start(Application.java:90)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:95)
	... 10 more
Caused by: java.lang.RuntimeException: Unable to start HTTP server
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.doServerStart(VertxHttpRecorder.java:501)
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.startServer(VertxHttpRecorder.java:224)
	at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket-2064782366.deploy_0(VertxHttpProcessor$openSocket-2064782366.zig:136)
	at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket-2064782366.deploy(VertxHttpProcessor$openSocket-2064782366.zig:40)
	at io.quarkus.runner.ApplicationImpl.doStart(ApplicationImpl.zig:620)
	... 12 more
Caused by: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999)
	at io.quarkus.vertx.http.runtime.VertxHttpRecorder.doServerStart(VertxHttpRecorder.java:467)
	... 16 more
Caused by: java.net.BindException: Address already in use
	at java.base/sun.nio.ch.Net.bind0(Native Method)
	at java.base/sun.nio.ch.Net.bind(Net.java:455)
	at java.base/sun.nio.ch.Net.bind(Net.java:447)
	at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:227)
	at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
	at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
	at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
	at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
	at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)
	at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248)
	at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasksFrom(SingleThreadEventExecutor.java:428)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:377)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:488)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	... 1 more

xumk · 2020-10-15T09:24:56Z

@gastaldi I am fixed it

… on quarkus.http.port

gastaldi

Works as advertised. Good job!

xumk · 2020-10-19T15:11:16Z

@gsmet @geoand approve please, for PR to be counted in hacktoberfest

gastaldi previously approved these changes Oct 13, 2020

View reviewed changes

gastaldi added this to the 1.10 - master milestone Oct 13, 2020

gastaldi added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 13, 2020

geoand reviewed Oct 13, 2020

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/dev/IsolatedDevModeMain.java Outdated Show resolved Hide resolved

geoand reviewed Oct 13, 2020

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/dev/IsolatedDevModeMain.java Outdated Show resolved Hide resolved

gastaldi removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 13, 2020

xumk force-pushed the helpful-bindexception branch from 20434c5 to 72dd941 Compare October 13, 2020 14:28

geoand approved these changes Oct 13, 2020

View reviewed changes

gsmet removed the triage/backport? label Oct 13, 2020

xumk force-pushed the helpful-bindexception branch from ca30101 to 9cee739 Compare October 14, 2020 11:28

xumk requested review from gastaldi, geoand and gsmet October 14, 2020 11:29

xumk force-pushed the helpful-bindexception branch 4 times, most recently from 502c7ea to 137bb83 Compare October 15, 2020 09:20

xumk force-pushed the helpful-bindexception branch from 137bb83 to 4c7a57e Compare October 15, 2020 09:56

solved quarkusio#4890 Provide helpful error-message for BindException…

96f09ae

… on quarkus.http.port

xumk force-pushed the helpful-bindexception branch from 4c7a57e to 96f09ae Compare October 15, 2020 10:13

gastaldi approved these changes Oct 19, 2020

View reviewed changes

gastaldi added the triage/backport? label Oct 19, 2020

gastaldi merged commit ca4301e into quarkusio:master Oct 19, 2020

xumk deleted the helpful-bindexception branch October 22, 2020 07:47

gsmet modified the milestones: 1.10 - master, 1.9.1.Final Oct 27, 2020

gsmet removed the triage/backport? label Oct 27, 2020

gsmet mentioned this pull request Dec 4, 2020

Quarkus 1.10.2.final issue with SSL config #13703

Closed

Provide helpful error-message for BindException on quarkus.http.port #12683

Provide helpful error-message for BindException on quarkus.http.port #12683

Uh oh!

Conversation

xumk commented Oct 13, 2020 • edited by gastaldi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xumk commented Oct 13, 2020

Uh oh!

gastaldi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gastaldi commented Oct 13, 2020

Uh oh!

xumk commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoand left a comment

Choose a reason for hiding this comment

Uh oh!

gastaldi commented Oct 13, 2020

Uh oh!

gsmet commented Oct 13, 2020

Uh oh!

geoand commented Oct 13, 2020

Uh oh!

xumk commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gastaldi commented Oct 14, 2020

Uh oh!

xumk commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gastaldi left a comment

Choose a reason for hiding this comment

Uh oh!

xumk commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xumk commented Oct 13, 2020 •

edited by gastaldi

Loading

xumk commented Oct 13, 2020 •

edited

Loading

xumk commented Oct 14, 2020 •

edited

Loading

xumk commented Oct 15, 2020 •

edited

Loading

xumk commented Oct 19, 2020 •

edited

Loading