Skip to content

Change kafka testcontainer artifact name#2818

Merged
michalvavrik merged 3 commits intoquarkus-qe:mainfrom
gastaldi:kafka_testcontainers
Dec 4, 2025
Merged

Change kafka testcontainer artifact name#2818
michalvavrik merged 3 commits intoquarkus-qe:mainfrom
gastaldi:kafka_testcontainers

Conversation

@gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Dec 4, 2025

Summary

Quarkus BOM updated testcontainers to new mayor version 2.0.2 - quarkusio/quarkus#51314
In this version artfiact org.testcontainers:kafka is renamed to org.testcontainers:testcontainers-kafka
Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)
  • This change requires execution with OCP on Aarch64 (use run arm tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mocenas December 4, 2025 12:27
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor Author

gastaldi commented Dec 4, 2025

I guess it requires quarkus-qe/quarkus-test-framework#1771 to be merged/released first?

@mocenas
Copy link
Contributor

mocenas commented Dec 4, 2025

I guess it requires quarkus-qe/quarkus-test-framework#1771 to be merged/released first?

yep it does

@fedinskiy
Copy link
Contributor

fedinskiy commented Dec 4, 2025

Now the error is different.
I seems, that changing import junit.framework.AssertionFailedError to org.opentest4j.AssertionFailedError[1] in service-discovery/stork/src/test/java/io/quarkus/ts/stork/AbstractCommonTestCases.java should help
UPD: same for service-discovery/stork-custom/src/test/java/io/quarkus/ts/stork/custom/StorkCustomServiceDiscoveryAndLoadBalancerIT.java
[1] see link for AssertionFailedError https://docs.junit.org/5.0.1/api/org/junit/jupiter/api/Assertions.html

@fedinskiy
Copy link
Contributor

I took the liberty to push the commit into the branch myself. @mocenas @gastaldi please confirm, that you're okay with that

@gastaldi gastaldi force-pushed the kafka_testcontainers branch from 18c84db to c07978d Compare December 4, 2025 16:14
@gastaldi
Copy link
Contributor Author

gastaldi commented Dec 4, 2025

@fedinskiy I haven't seen your latest comment in time, so I pushed a fix now

- Replace `AssertionFailedError` with `fail` from JUnit across test files for consistency and clarity.
- Enhance test failure messages with detailed error descriptions for better debugging.
@gastaldi gastaldi force-pushed the kafka_testcontainers branch from c07978d to 2d5d1bf Compare December 4, 2025 16:16
@michalvavrik
Copy link
Member

I fixed compilation failures because this was blocking me in testing my utils PR.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; if validation build passes, I'll merge it and whatever follow-up may be necessary can be detected from the next daily build.

@michalvavrik michalvavrik merged commit 2c4787f into quarkus-qe:main Dec 4, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants