Support ion and keypadlock control.#21
Support ion and keypadlock control.#21qqaatw merged 5 commits intoqqaatw:masterfrom LW-Ho:feature/add-more-function
Conversation
qqaatw
left a comment
qqaatw
left a comment
There was a problem hiding this comment.
Thank you for your contribution, sorry didn't see this PR in the first place.
JciHitachi/model.py
Outdated
| "is_numeric": False, | ||
| "legacy_name": None, | ||
| "id2str": {}, | ||
| "legacy_name": "ion", |
There was a problem hiding this comment.
We don't add "new" legacy names anymore. They exist only for BC reasons that I have been lazy to resolve. Let's just use its regular name Ion (and please modify the PR in JciHitachiHA accordingly).
There was a problem hiding this comment.
You're adding a legacy name ion to it, and we don't do that anymore because it is "legacy".
Simply set legacy_name to None and use its regular name Ion instead. You can look at the Defrost below as an example.
There was a problem hiding this comment.
Thanks your response, i modify and push.
JciHitachi/model.py
Outdated
| "is_numeric": False, | ||
| "legacy_name": None, | ||
| "id2str": {}, | ||
| "legacy_name": "keypad_lock", |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 92.64% 87.45% -5.20%
==========================================
Files 8 8
Lines 789 789
==========================================
- Hits 731 690 -41
- Misses 58 99 +41 ☔ View full report in Codecov by Sentry. |
|
Let me know if you run into any issue. |
Sorry, I don't understand what you mean, so I don't know what to modify. |
2 participants
購買了 RD-200HH1，也試圖使用API 控制該兩項功能，且都能運作。