Skip to content

Mask out active mods when unregistering after retro tapping#26127

Open
filterpaper wants to merge 1 commit intoqmk:developfrom
filterpaper:retro-tapping-fix
Open

Mask out active mods when unregistering after retro tapping#26127
filterpaper wants to merge 1 commit intoqmk:developfrom
filterpaper:retro-tapping-fix

Conversation

@filterpaper
Copy link
Copy Markdown
Member

Description

Do not unregister modifiers still held by other keys

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Do not unregister modifiers still held by other keys
@filterpaper filterpaper requested a review from a team April 6, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] RETRO_TAPPING drops active Mod-Tap modifier due to shared global state

2 participants