Add RGB LED matrix driver and EEPROM for Ducky One 2 SF#26112
Open
illixion wants to merge 2 commits intoqmk:developfrom
Open
Add RGB LED matrix driver and EEPROM for Ducky One 2 SF#26112illixion wants to merge 2 commits intoqmk:developfrom
illixion wants to merge 2 commits intoqmk:developfrom
Conversation
Add custom MBIA045 16-bit PWM RGB LED driver for the Ducky One 2 SF, enabling per-key RGB lighting with 69 LEDs. The driver lives in a separate rgb_matrix_custom.c as requested in prior review. - Add rgb_matrix_custom.c with MBIA045 LED matrix driver - Add RGB matrix LED layout (69 LEDs) and feature flag to keyboard.json - Enable breathing, cycle_left_right, and typing_heatmap by default - Add SRC to rules.mk - Update readme to reflect RGB support
Enable wear-leveling EEPROM backed by NUC123 on-chip APROM flash so that RGB settings (mode, hue, saturation, brightness, speed) survive power cycles. The NUC123 previously fell back to EEPROM_TRANSIENT because it is not in QMK's vendor auto-selection list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add RGB LED support and EEPROM persistence for the Ducky One 2 SF (DKON1967ST).
This continues the work originally started by Hayley in PR #22707, modernized for current QMK and with prior PR review feedback addressed:
rgb_matrix_custom.cfiledevelopbranchRGB Matrix driver (
rgb_matrix_custom.c): Implements a custom 16-bit PWM driver for the MBIA045 LED controller, providing per-key RGB lighting for all 69 LEDs. The driver exports the standardrgb_matrix_driver_tinterface (init, set_color, set_color_all, flush).EEPROM persistence: The NUC123 MCU is not in QMK's vendor EEPROM auto-selection list, so it falls back to
EEPROM_TRANSIENTand loses all settings on power-off. This PR enables wear-leveling EEPROM backed by the on-chip APROM flash (2 KB backing store → 1 KB logical EEPROM), so RGB mode/hue/saturation/brightness/speed persist across power cycles. Note:BACKING_STORE_WRITE_SIZEis defined explicitly because QMK's auto-detection checksQMK_MCU_FAMILY_NUC123but the build system generatesQMK_MCU_FAMILY_NUMICROfor this MCU family.Types of Changes
Issues Fixed or Closed by This PR
Checklist