Fix info.json in subfolder not overriding info.json in top-level folder#26044
Open
bosjaH wants to merge 1 commit intoqmk:developfrom
Open
Fix info.json in subfolder not overriding info.json in top-level folder#26044bosjaH wants to merge 1 commit intoqmk:developfrom
bosjaH wants to merge 1 commit intoqmk:developfrom
Conversation
bosjaH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where more specific json configuration files could not override settings set at a more general level.
Description
The only non-test change I made is reverse the order in which merge_info_json processes files. The issue is that the result from the find_info_json is ordered from most specific (child) to most general (parent).
Types of Changes
Issues Fixed or Closed by This PR
#Checklist