[Keyboard] Add Cheapino #25817
[Keyboard] Add Cheapino #25817
Conversation
azzamsa
force-pushed
the
add-cheapino-to-upstream
branch
from
7480ed0 to
6f9cb69
Compare
azzamsa
force-pushed
the
add-cheapino-to-upstream
branch
from
6f9cb69 to
6714833
Compare
azzamsa
force-pushed
the
add-cheapino-to-upstream
branch
7 times, most recently
from
f606211 to
582d5d6
Compare
azzamsa
force-pushed
the
add-cheapino-to-upstream
branch
from
582d5d6 to
0c6371d
Compare
There was a problem hiding this comment.
Is there a specific reason that the MATRIX_HAS_GHOST isn't being used in favor of this custom code?
There was a problem hiding this comment.
please update the pin functions to use the standard gpio function names:
https://docs.qmk.fm/drivers/gpio
There was a problem hiding this comment.
Probably could use the standard encoder feature here, but with the custom driver.
The ploopy devices have an example of this, but basically....
The press should be handled as a normal position in the matrix (and appears to be wired as such... so hard coding the behavior here is ... wrong).
And mostly, just need an encoder_driver_task function to run the encoder logic, and call encoder_queue_event(index, clockwise) based on behavior (eg, call peek matrix, and handle based on that)
|
|
||
| // Pick good defaults for enabling homerow modifiers | ||
| #define TAPPING_TERM 230 |
There was a problem hiding this comment.
Is a user setting and should be left there.
| // Pick good defaults for enabling homerow modifiers | |
| #define TAPPING_TERM 230 |
| #define WS2812_DI_PIN GP16 // The pin connected to the data pin of the LEDs | ||
| #define RGBLIGHT_LED_COUNT 1 // The number of LEDs connected | ||
|
|
||
| #define MAX_DEFERRED_EXECUTORS 32 |
There was a problem hiding this comment.
default is 8, and you're only using 1 here.
| #define MAX_DEFERRED_EXECUTORS 32 |
Worst case, if you're concerned about this, you can use a custom table for the executors for the kb stuff.
| #define RGBLIGHT_DEFAULT_HUE 128 // Sets the default hue value, if none has been set | ||
| #define RGBLIGHT_DEFAULT_SAT 128 // Sets the default saturation value, if none has been set | ||
| #define RGBLIGHT_DEFAULT_VAL \ | ||
| 32 // Sets the default brightness value, if none has been set |
There was a problem hiding this comment.
can be moved to json (qmk migrate or qmk info -kb (name) -f json can help with that)
3 participants
Description
Add support for Cheapino
Types of Changes
Issues Fixed or Closed by This PR
Checklist