-
Notifications
You must be signed in to change notification settings - Fork 425
兼容php8.1和php8.2 #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
兼容php8.1和php8.2 #380
Conversation
During inheritance of ArrayAccess
During inheritance of ArrayAccess
with PHP8.1
视而不见吗。。。 |
@tianyiw2013 我们内部会做审查的 |
合并一下啊,PHP8以后都会报错 |
一共就加了几行代码,看一眼不就审查完了吗,你们这审查流程是不是太复杂了? |
@coding-linheng @tianyiw2013 您好,十分抱歉回复晚了。 目前 PHP SDK 支持的版本为 但目前有几个事情还有困难:
基于以上原因,难以同时保证不同 PHP 版本用户的使用。 目前可能的一个途径是使用 PHPCompatibility 来完成这一兼容性问题,还在调研中。 由于还有其他工作内容,进度确实比较慢,还请海涵。🙏 |
During inheritance of ArrayAccess
with PHP8.1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lihsai0 您好,麻烦审核一下!不影响旧版本PHP!!!
@tianyiw2013 久等了。非常感谢您的 PR。 使用目前的测试用例测试下来,基本通过。 主要修改内容:
需要进一步修改,所以新建了一个 PR(#388):
|
谢谢,我关闭该PR了 |
@lihsai0 if (
!is_null($body)
&& strlen($body) > 0
&& isset($headers["Content-Type"])
&& $headers["Content-Type"] != "application/octet-stream"
) {
} |
不影响低版本PHP!!!
During inheritance of ArrayAccess
Creation of dynamic property Qiniu\Config::$zone is deprecated
strlen(): Passing null to parameter #1 ($string) of type string is deprecated