Skip to content

Change deprecated interfaces of IDA#1145

Merged
kabeor merged 1 commit intoqilingframework:devfrom
machinewu:dev2
May 1, 2022
Merged

Change deprecated interfaces of IDA#1145
kabeor merged 1 commit intoqilingframework:devfrom
machinewu:dev2

Conversation

@machinewu
Copy link
Contributor

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


Just recreate a PR for part of #1095.

Some minor fixes:

  1. According to IDA's IDAPython official documentation, some of the old methods have changed names for a long time. In IDA v7.7, some methods are no longer available. Follow the documentation to change the method in qiling/extensions/idaplugin/qilingida.py.

@kabeor
Copy link
Member

kabeor commented May 1, 2022

@machinewu Hi, is your code still works well on 7.6 and earlier version?

@machinewu
Copy link
Contributor Author

Maybe. I remember that I tested it before on 7.2 and it worked. I use 7.7 can work.

@xwings
Copy link
Member

xwings commented May 1, 2022

Maybe. I remember that I tested it before on 7.2 and it worked. I use 7.7 can work.

So, this code is specific for 7.7 and above ?
If we take in this changes, only work for 7.7 ?

If this so, we need to do a version check

@machinewu
Copy link
Contributor Author

I just test 7.2 & 7.7

@xwings
Copy link
Member

xwings commented May 1, 2022

I just test 7.2 & 7.7

U mean this code works on both ?

@machinewu
Copy link
Contributor Author

I just test 7.2 & 7.7

U mean this code works on both ?

yes

@kabeor kabeor merged commit 7c6b804 into qilingframework:dev May 1, 2022
@kabeor
Copy link
Member

kabeor commented May 1, 2022

Thank you for your contribution! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants