Rename min_area() and max_area() methods #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 92.54% 92.53% -0.01%
==========================================
Files 251 251
Lines 36761 36768 +7
==========================================
+ Hits 34022 34025 +3
- Misses 2739 2743 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Sure, I can do that. But as those are not shown by default, practically no-one using this feature would ever see the warning. |
djhoese
added
the
backwards-incompatibility
djhoese
reviewed
Feb 24, 2021
djhoese
approved these changes
Feb 24, 2021
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clarify naming, this PR renames the
Scene.min_area()andScene.max_area()to.coarsest_area()and.finest_area(), respectively. The original naming was causing confusion what was meant: ismin_area()the "geographically smallest area in the scene", "area with smallest pixels (highest resolution)" or "area of the data with smallest resolution (highest resolution)"? The new naming introduced in this PR got consensus in Slack, so lets use these. Warnings about the naming changes have been added.